Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Firefox headless where appropriate. #818

Merged
merged 2 commits into from
May 17, 2018
Merged

Conversation

manthey
Copy link
Contributor

@manthey manthey commented May 16, 2018

Significantly reduce the number of external web requests made by Firefox and Chrome during testing.

Significantly reduce the number of external web requests made by Firefox
and Chrome during testing.
@manthey
Copy link
Contributor Author

manthey commented May 16, 2018

When running headless tests while some web services were slow, the tests were oddly slower. As the headless tests do not themselves make any external requests, it was surprising. Both Chrome and Firefox make many external requests when starting, even in headless and incognito modes. By adding appropriate flags and preferences, many of the requests are no longer made. When there is a good network connection, this speeds up the overall tests a small amount (1 or 2 percent based on a limited set of runs). When there is a bad network connection, this has a much bigger impact.

Firefox still makes external connections the first time 2D canvas is used. Chrome still contacts google.com once.

karma-base.js Outdated
'datareporting.healthreport.uploadEnabled': false,
'datareporting.policy.dataSubmissionEnabled': false,
'media.gmp-gmpopenh264.autoupdate': false,
'media.gmp-manager.url': ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you dedup the common parts of these prefs objects?

@manthey manthey merged commit e32c8c8 into master May 17, 2018
@manthey manthey deleted the browser-test-improvements branch May 17, 2018 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants