Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jasmine and some tutorial testing infrastructure. #837

Merged
merged 1 commit into from
Jul 9, 2018

Conversation

manthey
Copy link
Contributor

@manthey manthey commented Jun 5, 2018

This upgrades to jasmine 3.1 and also the karma-jasmine-html-reporter. There are clearer tutorial test failure messages, especially when the test throws an exception.

Fixed some wording in the contour tutorial.

A small performance improvement was made to the gl.lineFeature.

This upgrades to jasmine 3.1 and also the karma-jasmine-html-reporter.
There are clearer tutorial test failure messages, especially when the
test throws an exception.

Fixed some wording in the contour tutorial.

A small performance improvement was made to the gl.lineFeature.
Copy link
Member

@aashish24 aashish24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manthey with this PR, we chose to use fixed versions numbers as opposed to range. Wondering the reasoning/advantage behind it.

@manthey
Copy link
Contributor Author

manthey commented Jul 9, 2018

You are referring to npm's package-lock.json file, which is essentially opaque to us -- we just generate it so that we get consistent builds. Different versions of npm frequently change how they store information in the package-lock, and I haven't bothered to learn why.

@manthey manthey merged commit 86dd841 into master Jul 9, 2018
@manthey manthey deleted the update-jasmine branch July 9, 2018 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants