Add more support for testing examples. #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this, all example testing was done via image comparison, which is relatively heavy to add. This mimics the testing support in tutorials, where examples can test if their dom or internal state matches expected values. These are different tests than image comparison, but should facilitate adding basic tests to most examples. Also, this now loads an example's javascript at the end of the body rather than at the end of the head. This allows skipping the onready callback.
|
This closes #329, as the infrastructure is fully in place. |
aashish24
approved these changes
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, all example testing was done via image comparison, which is relatively heavy to add. This mimics the testing support in tutorials, where examples can test if their dom or internal state matches expected values. These are different tests than image comparison, but should facilitate adding basic tests to most examples.
Also, this now loads an example's javascript at the end of the body rather than at the end of the head. This allows skipping the onready callback.