Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve feature event documentation. #872

Merged
merged 3 commits into from
Jul 27, 2018
Merged

Improve feature event documentation. #872

merged 3 commits into from
Jul 27, 2018

Conversation

manthey
Copy link
Contributor

@manthey manthey commented Jul 13, 2018

No description provided.

src/event.js Outdated
* The event contains the `feature`, the `mouse` record, the `previous`
* record of data elements that were under the mouse, and `over`, the new
* record of data elements that are unrder the mouse.
* This is triggered when the mouse changes either the feature components or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for consistency with the earlier texts, I think it could be "this event is fired"....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

@manthey manthey force-pushed the update-event-docs branch from bf8047e to 76a51c7 Compare July 23, 2018 14:33
Copy link
Member

@aashish24 aashish24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the improvements

@manthey manthey merged commit 3674e3c into master Jul 27, 2018
@manthey manthey deleted the update-event-docs branch July 27, 2018 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants