Update to the latest proj4. #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proj4 now uses rollup, which changes how it gets imported. proj4 is now pickier about coordinates. Before it accepted a string and cast it to a float. Now it must be cast before hand.
aashish24
approved these changes
Jul 27, 2018
| proj4.Proj.projections.add(require('proj4/projections/ortho')); | ||
| proj4 = proj4.__esModule ? proj4.default : proj4; | ||
| /* Ensure all projections in proj4 are included. */ | ||
| var projections = require.context('proj4/projections', true, /.*\.js$/); |
| @@ -254,7 +255,7 @@ transform.transformCoordinates = function ( | |||
|
|
|||
| var trans = transform({source: srcPrj, target: tgtPrj}), output; | |||
| if (util.isObject(coordinates) && 'x' in coordinates && 'y' in coordinates) { | |||
| output = trans.forward({x: coordinates.x, y: coordinates.y, z: coordinates.z || 0}); | |||
| output = trans.forward({x: +coordinates.x, y: +coordinates.y, z: +coordinates.z || 0}); | |||
There was a problem hiding this comment.
curious ..what does plus do here?
There was a problem hiding this comment.
@manthey the reason I did not approve it earlier, as I had a question on the signs. I approve it now, but still curious. is that because of the notation that is now enforced?
There was a problem hiding this comment.
+ casts a string to a float but does nothing to a float. It is cheaper than Number(<string or number>).
There was a problem hiding this comment.
A quick test shows the + takes 60% of the time of Number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proj4 now uses rollup, which changes how it gets imported.
proj4 is now pickier about coordinates. Before it accepted a string and cast it to a float. Now it must be cast before hand.