Fix a possible polygon feature update after delete. #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbeezley
approved these changes
Aug 30, 2018
On a geo.gl.polygonFeature with stroke, the update can be delayed one animation frame. If the polygonFeature is deleted during that delay, this could throw an error due to the styles of the feature being reset as part of the deletion process. This unschedules the update. This PR also introduces a `ready` property to features to ensure deleted features are not drawn. This makes `m_this` references in the feature module more consistent.
manthey
force-pushed
the
fix-update-after-delete
branch
from
c142dee to
b6db070
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a
geo.gl.polygonFeaturewith stroke, the update can be delayed one animation frame. If the polygonFeature is deleted during that delay, this could throw an error due to the styles of the feature being reset as part of the deletion process. This unschedules the update.This PR also introduces a
readyproperty to features to ensure deleted features are not drawn.This makes
m_thisreferences in the feature module more consistent.