Add an option to the tutorial editors to keep history in the browser. #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aashish24, @johnkit, @matthewma7 Request for comments: should this be the default behavior of the editor tutorials? Or is it too specialized and shouldn't be merged? Opinions desired. |
If `keep=history` is in the tutorial's url, in addition to add the source code to the window's location, the back button will return to the previously source code of the tutorial. I'm finding this is handy when using the editor to try out experimental code, as those experiments are in the browser's history. However, this has been left as an option that has to be explicitly enabled, as if you make many small edits, the history is very long and tedious without a good indicator of when something significant or interesting occurred.
manthey
force-pushed
the
tutorial-history
branch
from
2020ff8 to
8702dbc
Compare
|
This is a feature that I could use myself. |
|
We already debounce updates to an extent to prevent rerunning the tutorials as you are typing, so it probably is fine. If no one else chimes in, I'll make it always push to history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
keep=historyis in the tutorial's url, in addition to add the source code to the window's location, the back button will return to the previously source code of the tutorial.I'm finding this is handy when using the editor to try out experimental code, as those experiments are in the browser's history. However, this has been left as an option that has to be explicitly enabled, as if you make many small edits, the history is very long and tedious without a good indicator of when something significant or interesting occurred.