Rename renderers #965
Merged
Rename renderers #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alias it to d3 so as to not break existing code.
Alias it to vgl so as to not break existing code.
manthey
force-pushed
the
rename-renderers
branch
from
db4bee5 to
86a763b
Compare
This allows the checkRenderer function to return the preferred name of the renderer, rather than the passed alias.
aashish24
reviewed
Dec 4, 2018
| if (m_gl_polygons) { | ||
| for (var idx = 0; idx < m_gl_polygons.length; idx += 1) { | ||
| m_gl_polygons[idx].draw(); | ||
| if (m_polygons) { |
aashish24
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the d3 renderer to svg. Alias it to d3 so as to not break existing code.
Rename the vgl renderer to webgl. Alias it to vgl so as to not break existing code.
Update the baseline images; many were renamed.
This resolves #898.