Autoshare webgl renderers. #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manthey
force-pushed
the
auto-merge-contexts
branch
from
0fe47be to
c45b678
Compare
manthey
force-pushed
the
shared-context-visibility
branch
2 times, most recently
from
563a1ae to
4faef39
Compare
Autosharing is now the default. Renderers can be manually shared, and
webgl layers can be manually be moved to different renderer.
To manually move a layer to a different renderer, for instance, given
two layers: `var layer1 = map.createLayer('feature', {renderer: 'webgl',
autoshareRenderer: false}); var layer2 = map.createLayer('feature',
{renderer: layer1.renderer(), autoshareRenderer: false});`, the second
layer can be moved to a new renderer by doing:
`layer2.switchRenderer(geo.createRenderer('webgl', layer2), true);`.
manthey
force-pushed
the
auto-merge-contexts
branch
from
c45b678 to
d1ac4a3
Compare
|
@manthey I am still reviewing this branch.. mostly done just has one or two things that I need to clear my self. |
aashish24
approved these changes
Apr 3, 2019
|
Can you also review OpenGeoscience/vgl#106, as this depend on it? |
|
done. |
aashish24
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autosharing is now the default. Renderers can be manually shared, and webgl layers can be manually be moved to different renderer.
To manually move a layer to a different renderer, for instance, given two layers:
var layer1 = map.createLayer('feature', {renderer: 'webgl', autoshareRenderer: false}); var layer2 = map.createLayer('feature', {renderer: layer1.renderer(), autoshareRenderer: false});, the second layer can be moved to a new renderer by doing:layer2.switchRenderer(geo.createRenderer('webgl', layer2), true);.This requires an update to vgl to work.