Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Networks & File Items #46

Merged
merged 10 commits into from
Aug 21, 2024
Merged

Networks & File Items #46

merged 10 commits into from
Aug 21, 2024

Conversation

annehaley
Copy link
Collaborator

@annehaley annehaley commented Aug 2, 2024 •
edited
Loading

This PR consolidates the models changes from #45, which will be rebased on this branch.

  • Make the FileItem relationship optional (datasets can be created without files)
  • Add a Network model to consolidate network logic and allow multiple disparate networks on the same dataset
  • Add rest endpoints for FileItem and Network models
  • Add a test for the load_roads task
  • Fix a bug in the charts endpoint for a context

Switching to this branch will require a migration.

@annehaley annehaley changed the base branch from master to freeze-deps August 2, 2024 18:21
@annehaley annehaley marked this pull request as ready for review August 2, 2024 18:43
@annehaley annehaley requested a review from jjnesbitt August 2, 2024 18:43
Base automatically changed from freeze-deps to master August 19, 2024 18:59
jjnesbitt
jjnesbitt requested changes Aug 20, 2024
View reviewed changes
uvdat/core/rest/chart.py Outdated Show resolved Hide resolved
uvdat/core/tests/test_load_roads.py Outdated Show resolved Hide resolved
uvdat/core/rest/dataset.py Outdated Show resolved Hide resolved
uvdat/core/tasks/chart.py Outdated Show resolved Hide resolved
@jjnesbitt
Copy link
Member

Once the linting error is fixed I think this is good to go

@annehaley annehaley merged commit 79e6ca7 into master Aug 21, 2024
4 checks passed
@annehaley annehaley deleted the model-changes branch August 21, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjnesbitt jjnesbitt jjnesbitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annehaley @jjnesbitt