Implement GCC algorithm in native Postgres #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnesbitt
force-pushed
the
postgres-gcc-query
branch
3 times, most recently
from
bcf5cc9 to
93c53a9
Compare
annehaley
reviewed
Sep 25, 2024
There was a problem hiding this comment.
Impressive time delta. The original implementation was done with networkx, so I'm not sure about the semantics of the previous algorithm. This new method seems reasonable. Could you either remove the old get_gcc method from the Network model or move this logic there?
jjnesbitt
force-pushed
the
postgres-gcc-query
branch
from
9e532b2 to
5a6bc7b
Compare
annehaley
approved these changes
Sep 30, 2024
jjnesbitt
force-pushed
the
postgres-gcc-query
branch
from
5a6bc7b to
1eadf03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're dealing with larger networks now (i.e. the boston roads dataset), the current algorithm for finding the GCC doesn't perform well enough. An example query on the boston roads dataset takes ~46 seconds. That same query takes ~40ms with this native Postgres query.
@annehaley PTAL and let me know if this maintains the same semantics as the original query.