Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing DTU and Eurostag models. #10

Merged
merged 1 commit into from
Apr 19, 2016
Merged

Removing DTU and Eurostag models. #10

merged 1 commit into from
Apr 19, 2016

Conversation

tinrabuzin
Copy link

No description provided.

@MaximeBaudette
Copy link
Member

@tinrabuzin
You removed the sensor package. The PwVoltageCurrent sensor is used in Controls.PSSE.ES.ESST4B

@tinrabuzin
Copy link
Author

@MaximeBaudette I did it intentionally. I will reimplement ESST4B without the sensor. I think that's the only component that uses sensors.

@MaximeBaudette MaximeBaudette merged commit 8907c02 into OpenIPSL:master Apr 19, 2016
@tinrabuzin tinrabuzin deleted the RemoveEurotrashAndDTU branch April 19, 2016 11:48
@NiDingRte
Copy link

Hello,
I am working on the eurostag components in the ipsl package. I would like to know the reason why you have removed these components out of the OpenIPSL package? The OpenIPSL is not supposed to be an enhanced version of IPSL package?

Thx for your answer,
Regards,

@MaximeBaudette
Copy link
Member

Hello @NiDingRte

One of the main reasons for us removing most Eurostag models from the package is that those were not built like the other ones, mostly the dynamic models didn't include the initialization like the other models, but relied on a separate init model.
Also as we tried to harmonize the models throughout the library with common interfaces, our colleagues in charge of the Eurostag models were reluctant to do so... So in the end there was a certain harmonization gap between the rest of the library and the Eurostag models, leading to our decision to drop those models in this fork.

The intention for the OpenIPSL package, as I see it, is to propose a harmonized package, we are not there yet, but we have made substantial modifications already. It is not necessarily a better - or enhanced - package, mostly a more harmonized one. And also we are making effort to change it toward a more Modelica-like approach.

Best regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants