Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update interpreter.py for multi OS request #2

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

nirvor
Copy link
Contributor

@nirvor nirvor commented Aug 7, 2023

Hi, i got following error after your last commits (and trying them out :-) ) :

File "E:\Python311\Lib\site-packages\interpreter\interpreter.py", line 98, in get_info_for_system_message
operating_system = os.name if os.name != 'nt' else os.uname().sysname
AttributeError: module 'os' has no attribute 'uname'. Did you mean: 'name'?

After some time looking into it:

Its trying to call the method os.uname() on a Win system. However, the os.uname() function is not available on Windows systems, which is why the AttributeError is triggered.
-> A possible solution is to use the platform library to query the operating system,

These ( 1x import lib, 1x another os call ) I have changed (and tested on two Win machines). But iam just hobby coding, most probably you know another approach without using an additional package. Just wanted to help! :-)

for os request at different os (linux,win,mac...)
@nirvor
Copy link
Contributor Author

nirvor commented Aug 7, 2023

*just learned: First commit ever made on this (private) git account :-D Gz...

@KillianLucas KillianLucas merged commit 24fb69a into OpenInterpreter:main Aug 8, 2023
@KillianLucas
Copy link
Collaborator

thanks @nirvor! I'm on Mac + Linux so really appreciate the Windows testing and this fix. Great contribution and thanks for the explanation, in full agreement.

"free, cross-platform OS copilot" is somewhat the goal of this project so having some eyes and hands on Windows is extremely helpful. 🙏

joshuavial pushed a commit to joshuavial/open-interpreter that referenced this pull request Sep 7, 2023
Update interpreter.py for multi OS request
joshuavial pushed a commit to joshuavial/open-interpreter that referenced this pull request Sep 15, 2023
Update interpreter.py for multi OS request
joshuavial pushed a commit to joshuavial/open-interpreter that referenced this pull request Nov 16, 2023
Update interpreter.py for multi OS request

Former-commit-id: 24fb69a
Former-commit-id: 359b87aae3e14c040113e009f0948c37a36b49ad
Former-commit-id: 33b66b11d74a5a0c19149775e7ede022bdedb625 [formerly f86ae2b4ac8d0a38b2d5a6f7b2864c035603b387]
Former-commit-id: 7c33839f8361b39298c42244d418561e5a718bea
KillianLucas pushed a commit that referenced this pull request Apr 23, 2024
Removes extra new lines that were cluttering the console output
meslubi2021 added a commit to Banking-and-financial-institutions/open-interpreter that referenced this pull request Oct 27, 2024
…Local-llamafile.cpp-Ollama--models-2024-llamafile-.cpp-(llamafile-.cpp-,Ollama,Local-and-self-hosted-LLM-complete-guide

llamafile.mdx 2024 @6rz6 update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants