Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set correct permission for the test directory. #107

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

Honglichenn
Copy link
Contributor

@Honglichenn Honglichenn commented Apr 4, 2024

What was the problem/requirement? (What/Why)

test_shutdown test can pass without the delete permission of the file, which is affected by the parent folder's permission.

Note: This will only happen when the owner of the file and its parent directory is the same. If UserA creates a folder named FolderA and has the 'Delete subfolders and files' permission on that folder, then UserA can delete any files or subfolders within FolderA, even if UserA doesn't have explicit delete permissions on those individual files or subfolders, as long as UserA is the owner of those files or subfolders.

However, if UserA creates a folder named FolderA and has the 'Delete subfolders and files' permission on that folder, UserA cannot delete any files or subfolders within FolderA if those files or subfolders are owned by another user, such as UserB, even if UserA has the 'Delete subfolders and files' permission on the parent folder FolderA.

What was the solution? (How)

Remove the "Delete subfolders and files" of the parent folder of the connection file.

What is the impact of this change?

It will fail the test if the delete permission is missing.

How was this change tested?

I manually remove the delete permission of the connection file and the test will fail right now.

Was this change documented?

N/A

Is this a breaking change?

N/A


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Hongli Chen <honglich@amazon.com>
@Honglichenn Honglichenn marked this pull request as ready for review April 4, 2024 20:43
@Honglichenn Honglichenn requested a review from a team as a code owner April 4, 2024 20:43
Copy link
Contributor

@jericht jericht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into this and making our tests more robust. LGTM!

@epmog epmog merged commit 169f346 into mainline Apr 5, 2024
12 checks passed
@epmog epmog deleted the honglich/fix_test branch April 5, 2024 16:43
This was referenced Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants