Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add macOS socket support and enable macOS CI #65

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

jericht
Copy link
Contributor

@jericht jericht commented Jan 30, 2024

What was the problem/requirement? (What/Why)

We need to support macOS in the adaptor runtime.

What was the solution? (How)

This PR adds support for creating macOS sockets and adds macOS to the CI runners.

What is the impact of this change?

The adaptor runtime now supports macOS

How was this change tested?

  • Ran the unit tests on macOS and Linux
  • Morgan manually verified the macOS IPC authentication code works by manually running an adaptor in background mode on macOS:
app-openjd daemon start --connection-file ./connection.json --init-data file://./init-data.yml
...
app-openjd daemon run --connection-file ./connection.json --run-data file://./run-data.yml
...
app-openjd daemon stop --connection-file ./connection.json

Was this change documented?

No

Is this a breaking change?

No


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jericht jericht force-pushed the jericht/macos branch 2 times, most recently from fc9993a to 42470f6 Compare January 30, 2024 04:37
Signed-off-by: Jericho Tolentino <68654047+jericht@users.noreply.github.com>
@jericht jericht marked this pull request as ready for review February 29, 2024 01:36
@jericht jericht requested a review from a team as a code owner February 29, 2024 01:36
Signed-off-by: Morgan Epp <60796713+epmog@users.noreply.github.com>
@ddneilson ddneilson merged commit 4da070d into mainline Feb 29, 2024
12 checks passed
@ddneilson ddneilson deleted the jericht/macos branch February 29, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants