fix: Move the named_pipe_helper.py under the folder adaptor_runtime_client
#87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Honglichenn
force-pushed
the
honglich/move_namedpipe
branch
2 times, most recently
from
39f958a
to
b41d206
Compare
Honglichenn
changed the title
adaptor_runtime_client
Honglichenn
changed the title
adaptor_runtime_clientnamed_pipe_helper.py under the folder adaptor_runtime_client
Honglichenn
force-pushed
the
honglich/move_namedpipe
branch
from
b41d206
to
1fe5f04
Compare
Honglichenn
force-pushed
the
honglich/move_namedpipe
branch
from
45bdf86
to
2e88629
Compare
epmog
previously approved these changes
Mar 19, 2024
Honglichenn
force-pushed
the
honglich/move_namedpipe
branch
2 times, most recently
from
4affe2e
to
60349e2
Compare
epmog
approved these changes
Mar 19, 2024
epmog
approved these changes
Mar 19, 2024
…e_client` Signed-off-by: Hongli Chen <honglich@amazon.com>
…e_client` Signed-off-by: Hongli Chen <honglich@amazon.com>
ddneilson
force-pushed
the
honglich/move_namedpipe
branch
from
60349e2
to
bdf8c22
Compare
jericht
approved these changes
Mar 20, 2024
ddneilson
changed the title
named_pipe_helper.py under the folder adaptor_runtime_clientnamed_pipe_helper.py under the folder adaptor_runtime_client
ddneilson
changed the title
named_pipe_helper.py under the folder adaptor_runtime_clientnamed_pipe_helper.py under the folder adaptor_runtime_client
ddneilson
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Previously, we put the common named pipe code in the
named_pipe_helper.pyand this file exist in theadaptor_runtimefolder. However, when developing 3rd party adaptor, developer may be only import theadaptor_runtime_client, for example, this one. It will complain that thenamed_pipe_helper.pycannot be found.What was the solution? (How)
Put the
named_pipe_helper.pyunder theadaptor_runtime_clientfolder instead of theadaptor_runtime. For now, the server sideadaptor_runtimemust have the access to any code under theadaptor_runtime_client, so we won't have any issues.What is the impact of this change?
named_pipe_helper.pyis moved toadaptor_runtime_clientHow was this change tested?
Change the imports in the test code and all of them are passed.
Was this change documented?
N/A
Is this a breaking change?
Yes, but this won't affect any external code, because
named_pipe_helper.pyis only used internally.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.