Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding an initial set of sample templates #25

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

ddneilson
Copy link
Contributor

We are providing some sample Job/Environment Templates that users can reference to demonstrate the sorts of things that can be done with Open Job Description. This seeds an initial set of templates.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ddneilson ddneilson requested a review from a team as a code owner February 13, 2024 15:44
@ddneilson ddneilson marked this pull request as draft February 13, 2024 15:57
@ddneilson ddneilson force-pushed the initial_samples branch 4 times, most recently from c1b77c8 to 071b3b3 Compare February 13, 2024 16:07
Copy link
Contributor

@shidarin shidarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Half finished sentence.

CONTRIBUTING.md Outdated
@@ -3,21 +3,21 @@
Thank you for your interest in contributing to our project. Whether it's a bug report, new feature, correction, or additional
documentation, we greatly value feedback and contributions from our community.

Open Job Description is under active development. We're releasing this because we'd like your feedback and participation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to back out the style changes and submit as a separate PR so it can be a sep commit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I'll add the spaces back in.

can do with Open Job Description, and a reference set of demonstrations of template
concepts that you can incorporate in to your own templates.

All samples are provided AS-IS. We strongly recommend that you
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We strongly recommend that you test all samples thoroughly before use, and customize the samples as required by your individual needs.


For deeper insight into our thought process and goals, we recommend [this Academy Software Foundation talk](https://www.youtube.com/watch?v=3AM3L6P-cAw&list=PL9dZxafYCWmxDFGc2CEq4SgCkZWKYW1m5&index=14)
by Pauline Koh, Senior Product Manager at Amazon Web Services, titled
Open Job Description is a flexible open specification for defining render
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what it thinks that I changed here.

Summary:

We are providing some sample Job/Environment Templates that users can
reference to demonstrate the sorts of things that can be done
with Open Job Description. This seeds an initial set of templates.

Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com>
@ddneilson ddneilson marked this pull request as ready for review February 13, 2024 16:20
@ddneilson ddneilson requested a review from shidarin February 13, 2024 16:21
@ddneilson ddneilson merged commit f089192 into OpenJobDescription:mainline Feb 13, 2024
4 checks passed
@ddneilson ddneilson deleted the initial_samples branch February 13, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants