Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds a sample job template that runs scripts in docker #38

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

ddneilson
Copy link
Contributor

Summary:

Prompted by a question in the discussion forums, this adds a very basic sample that demonstrates how one might run Tasks within a docker container.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ddneilson ddneilson requested a review from a team as a code owner April 3, 2024 14:19
Copy link
Contributor

@jusiskin jusiskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One small suggestion to simplify starting the container in the background

samples/v2023-09/job_templates/bash-in-docker.yaml Outdated Show resolved Hide resolved
Summary:

Prompted by a question in the discussion forums, this adds a very basic
sample that demonstrates how one might run Tasks within a docker
container.

Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com>
@ddneilson ddneilson requested a review from jusiskin April 3, 2024 14:54
@ddneilson ddneilson enabled auto-merge (squash) April 3, 2024 14:56
@ddneilson ddneilson merged commit dfae773 into OpenJobDescription:mainline Apr 3, 2024
4 checks passed
@ddneilson ddneilson deleted the docker_example branch April 3, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants