Skip to content

Commit

Permalink
update documentation and TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
KyleAure committed Sep 21, 2022
1 parent 0dd3d70 commit ecb9d5d
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 7 deletions.
6 changes: 3 additions & 3 deletions dev/io.openliberty.jakarta.concurrency.3.0_fat_tck/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ cd concurrency-api
mvn clean install
```

The API and TCK libraries will be tagged with the `3.0.0-SNAPSHOT` version. Keep this in mind if you plan to follow the [Running the TCK for Verification](#Running-the-TCK-for-Verification) section.
The API and TCK libraries will be tagged with the `3.0.2-SNAPSHOT` version. Keep this in mind if you plan to follow the [Running the TCK for Verification](#Running-the-TCK-for-Verification) section.

### Getting Open Liberty

Expand Down Expand Up @@ -124,11 +124,11 @@ mvn clean test -B \
```

By default the TCK will run against a staged version of Jakarta API and TCK uploaded to sonatype.
If you want to test against a local `3.0.0-SNAPSHOT` then set these properties on the command above:
If you want to test against a local `3.0.2-SNAPSHOT` then set these properties on the command above:

```txt
-Djakarta.concurrent.tck.groupid=jakarta.enterprise.concurrent \
-Djakarta.concurrent.tck.version=3.0.0-SNAPSHOT
-Djakarta.concurrent.tck.version=3.0.2-SNAPSHOT
```

Finally, remember to stop the running server
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ dependencies {

arquillian 'io.openliberty.arquillian:arquillian-liberty-support-jakarta:2.0.1'

//TODO configure WLP dependency, Example below:
//TODO Configure WLP dependency if doing verification testing, Example below:
//wlp 'io.openliberty.beta:openliberty-runtime:22.0.0.3-beta@zip'
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ public static void setUp() throws Exception {
//UNCOMMENT - To test against a local snapshot of TCK
// additionalProps.put("jakarta.concurrent.tck.groupid", "jakarta.enterprise.concurrent");
// additionalProps.put("jakarta.concurrent.tck.version", "3.0.2-SNAPSHOT");
// additionalProps.put("jakarta.run.full.profile", "false");

//username and password for Arquillian to authenticate to restConnect
additionalProps.put("tck_username", "arquillian");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@
<properties>
<!-- These properties can be overwritten by users if they want to test against a snapshot version-->
<jakarta.concurrent.tck.groupid>jakarta.enterprise.concurrent</jakarta.concurrent.tck.groupid>
<jakarta.concurrent.tck.version>3.0.0</jakarta.concurrent.tck.version> <!-- TODO update to 3.0.2 -->
<jakarta.concurrent.tck.version>3.0.2</jakarta.concurrent.tck.version>

<jakarta.concurrent.version>3.0.0</jakarta.concurrent.version> <!-- TODO update to 3.0.2 -->
<jakarta.concurrent.version>3.0.2</jakarta.concurrent.version>

<arquillian.version>1.7.0.Alpha12</arquillian.version>
<arquillian-wlp.version>2.1.0</arquillian-wlp.version>
Expand Down

0 comments on commit ecb9d5d

Please sign in to comment.