Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable BELL properties for BETA #21708

Merged
merged 3 commits into from
Jul 18, 2022
Merged

Enable BELL properties for BETA #21708

merged 3 commits into from
Jul 18, 2022

Conversation

dazavala
Copy link
Contributor

The implementation and FAT for BELL properties support pursuant to socialized design changes.

@dazavala dazavala self-assigned this Jul 11, 2022
@dazavala dazavala force-pushed the EnableBellProperties branch 5 times, most recently from 4c8c8c6 to 96bf9f9 Compare July 11, 2022 18:32
@dazavala dazavala requested review from tjwatson July 11, 2022 18:34
@dazavala
Copy link
Contributor Author

#build
#libbybot

@dazavala
Copy link
Contributor Author

dazavala commented Jul 11, 2022 •
edited
Loading

@tjwatson FYI, these changes do not perform a non-destructive update on BELL service implementation instances when the user changes a BELL configuration. We can address this at review; introducing the behavior requires significant change to the feature design. Note also, a non-destructive update is feasible only when properties are updated. Any change to SPI visibility or the referenced library from the previous generation will require a destructive BELL update.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_jlIg0AFNEe2_YeU2rrO1jw

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

The build dazavala-21708-20220711-1320
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_jlIg0AFNEe2_YeU2rrO1jw
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_jlIg0AFNEe2_YeU2rrO1jw

@dazavala
Copy link
Contributor Author

#build
#libby

@dazavala
Copy link
Contributor Author

#build

@dazavala dazavala force-pushed the EnableBellProperties branch 2 times, most recently from ce122d7 to d9b476d Compare July 13, 2022 20:09
@dazavala
Copy link
Contributor Author

#build

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_DPhM0ALsEe2_YeU2rrO1jw

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_u0jVwALxEe2_YeU2rrO1jw

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_xpkeQAL1Ee2_YeU2rrO1jw

Target locations of links might be accessible only to IBM employees.

@dazavala dazavala requested a review from ramkumar-k-9286 July 14, 2022 13:40
@dazavala
Copy link
Contributor Author

#build

@dazavala dazavala marked this pull request as ready for review July 14, 2022 14:26
@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_otKigAN6Ee2_YeU2rrO1jw

Target locations of links might be accessible only to IBM employees.

@dazavala dazavala force-pushed the EnableBellProperties branch from d9b476d to e1ff30b Compare July 14, 2022 17:19
@dazavala
Copy link
Contributor Author

#build

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_KksrkAOlEe2_YeU2rrO1jw

Target locations of links might be accessible only to IBM employees.

@dazavala dazavala linked an issue Jul 14, 2022 that may be closed by this pull request
Enhance the bells-1.0 feature to support the configuration of BELL service properties #17414
Closed
@LibbyBot
Copy link

The build dazavala-21708-20220714-0753
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_otKigAN6Ee2_YeU2rrO1jw
completed successfully!

@dazavala
Copy link
Contributor Author

#libbybot

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 4 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 21 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 1 messages files were changed and need an L2 review.

  • @OpenLiberty/message-reviewer Please review.

  • dev/com.ibm.ws.classloading.bells/resources/com/ibm/ws/classloading/bells/internal/resources/BellConfigurationMessages.nlsprops

  • 2 NLS files were changed and need an ID review.

  • @OpenLiberty/message-reviewer Please review.

  • dev/com.ibm.ws.classloading.bells/resources/com/ibm/ws/classloading/bells/internal/resources/BellConfigurationMessages.nlsprops

  • dev/com.ibm.ws.classloading.bells/resources/OSGI-INF/l10n/bells.properties

@dazavala dazavala merged commit a24832c into OpenLiberty:integration Jul 18, 2022
@dazavala dazavala mentioned this pull request Jul 20, 2022
Closed
@dazavala dazavala deleted the EnableBellProperties branch July 7, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramkumar-k-9286 ramkumar-k-9286 ramkumar-k-9286 approved these changes

@tjwatson tjwatson tjwatson approved these changes

Assignees

@dazavala dazavala

Labels
CLA Signed ID reviewed team:OSGi Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance the bells-1.0 feature to support the configuration of BELL service properties
4 participants
@dazavala @LibbyBot @tjwatson @ramkumar-k-9286