Python version check bug

[JamCam]

Hi

Your python version check in OlaClient.py fails on Python 3.10

line 957
if sys.version >= '3.2':
request.data = data.tobytes()
else:
request.data = data.tostring()

The best solution I can see, others may have a better solution, is

pv = platform.python_version_tuple()
if int(pv[0]) >= 3 and int(pv[1]) > 2:
request.data = data.tobytes()
else:
request.data = data.tostring()

[peternewman]

Hi @JamCam ,

This has already been fixed:

ola/python/ola/OlaClient.py

Line 955 in e95de59

if sys.version_info >= (3, 2):

See #1757 .

You might need to run from source if you're doing stuff with Python 3, although unfortunately even there, there are a few outstanding issues. Some (but not all) are sorted in #1761 .

[peternewman]

Did that work for you @JamCam ?

Let us know if you see any other Python 3 related bugs during your usage of it.

[peternewman]

I'll close this as it's a duplicate of #1755 and was fixed in #1757 .