Fix vast majority of outstanding Python 3 issues #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into 0.10-c11-compat
…into 0.10-c11-compat
This reverts commit 67a5a9d.
Closed
peternewman
added a commit
that referenced
this pull request
Nov 20, 2022
Cherry-pick some easy stuff from #1761
Python 3 treats TestState and ola.testing.rdm.TestState as different and not instances of each other which breaks some functionality, so import them all fully qualified to avoid that.
…t to the bottom of the issue
This was referenced Nov 27, 2022
peternewman
changed the title
…o 0.10-c11-compat
…into 0.10-c11-compat
… we try to decode its invalid ASCII and UTF-8 values, a TODO for another day...
…o 0.10-c11-compat
Merged
…o 0.10-c11-compat
…s been merged" This reverts commit 0328b63.
kripton
approved these changes
Feb 25, 2023
| except NameError: | ||
| unicode = str | ||
|
|
||
| __author__ = 'nomis52@gmail.com (Simon Newton)' |
There was a problem hiding this comment.
any reason to not using your name as the author? you got it in line 16 as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found when trying to actually run the tools.
Untested on Python < 3.--list-testsand the RDM responder test class selection stuff inGetTestClassesdue to them not being loadedDownloadModelDatareturning blank info