Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shutter effect 'Burst' #1008

Closed
fxedel opened this issue Aug 20, 2019 · 0 comments · Fixed by #2094
Closed

Add shutter effect 'Burst' #1008

fxedel opened this issue Aug 20, 2019 · 0 comments · Fixed by #2094
Labels
component-fixture Affects one or more existing fixture definitions. component-schema Affects the fixture JSON schema. difficulty-easy Implementation is relatively straighforward. good first issue Easy to pick up for new contributors. Only little domain knowledge required. hacktoberfest Good issue for users participating in the Hacktoberfest.

Comments

@fxedel
Copy link
Member

fxedel commented Aug 20, 2019

As there are already some fixtures with shutter effect "Strobe" and comment "Burst", it may be worth adding this as a new shutter effect.

We only need to add the new value to the schema and update the corresponding fixtures.
@fxedel fxedel added component-fixture Affects one or more existing fixture definitions. difficulty-easy Implementation is relatively straighforward. component-schema Affects the fixture JSON schema. good first issue Easy to pick up for new contributors. Only little domain knowledge required. labels Aug 20, 2019
@fxedel fxedel added the hacktoberfest Good issue for users participating in the Hacktoberfest. label Sep 30, 2019
@FloEdelmann FloEdelmann mentioned this issue Aug 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component-fixture Affects one or more existing fixture definitions. component-schema Affects the fixture JSON schema. difficulty-easy Implementation is relatively straighforward. good first issue Easy to pick up for new contributors. Only little domain knowledge required. hacktoberfest Good issue for users participating in the Hacktoberfest.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Burst as new shutter effect
1 participant
@fxedel