Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Burst as new shutter effect #2094

Merged
merged 7 commits into from
Aug 20, 2021
Merged

Add Burst as new shutter effect #2094

merged 7 commits into from
Aug 20, 2021

Conversation

JonahKr
Copy link
Contributor

@JonahKr JonahKr commented Aug 8, 2021 •
edited by FloEdelmann
Loading

Closes #1008.

@FloEdelmann FloEdelmann changed the title Adds Burst as new ShutterEffect #1008 Adds Burst as new shutter effect Aug 19, 2021
@FloEdelmann FloEdelmann added component-fixture Affects one or more existing fixture definitions. component-schema Affects the fixture JSON schema. labels Aug 19, 2021
@FloEdelmann FloEdelmann changed the title Adds Burst as new shutter effect Add Burst as new shutter effect Aug 19, 2021
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-2094 August 19, 2021 20:47 Inactive
FloEdelmann
FloEdelmann approved these changes Aug 19, 2021
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

I've added a few commits and enabled the review app at https://open-fixture-library-pr-2094.herokuapp.com/.

Could you please check whether you are fine with the changes? From my side, this looks good now 😊

@JonahKr
Copy link
Contributor Author

JonahKr commented Aug 20, 2021

LGTM! 😄

@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-2094 August 20, 2021 11:43 Inactive
@FloEdelmann FloEdelmann merged commit 62fb8e7 into OpenLightingProject:master Aug 20, 2021
@FloEdelmann
Copy link
Member

Nice! It's merged and a new schema version is released 😊
https://github.com/OpenLightingProject/open-fixture-library/releases/tag/schema-12.3.0

Thanks again!

@FloEdelmann FloEdelmann mentioned this pull request Aug 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

Assignees
No one assigned
Labels
component-fixture Affects one or more existing fixture definitions. component-schema Affects the fixture JSON schema.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add shutter effect 'Burst'
2 participants
@JonahKr @FloEdelmann