Refactor plugins as of #112 and fix plugin diff with no fixtures #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fxedel
added
component-plugin
|
Last updated: 5/16/2017, 9:05:42 PM Diff plugin outputs testModified plugin
|
FloEdelmann
requested changes
May 16, 2017
plugins/ecue.js
Outdated
| @@ -3,30 +3,45 @@ const path = require('path'); | |||
| const util = require('util'); | |||
plugins/qlcplus.js
Outdated
| @@ -82,23 +97,29 @@ module.exports.export = function exportQLCplus(library, options) { | |||
|
|
|||
| function exportHandleAvailableChannels(fixture, defaults) { | |||
| let str = ''; | |||
There was a problem hiding this comment.
remove this unused variable
|
https://github.com/oozcitak/xmlbuilder-js/blob/master/src/XMLStringWriter.coffee#L130 There currently is no way to add the additional space without making changes to the dependency. But we could create an issue and ask whether it's possible/wished to add an option to the dependency that adds this extra space and then make a pull request implementing that functionality. However, it might be considerable whether this space is really that important. |
…ure-library into plugins-xmlbuilder
FloEdelmann
approved these changes
May 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.