-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor everything to ES Modules #1929
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but don't drop the dependency yet to not break the export-diff test
to ensures the correct decodings of percent-encoded characters and cross-platform valid absolute path string
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes from #1626 again, which has been reverted in #1926.
Since #1930 is now merged, we shouldn't have to wait for Unitech/pm2#4540 to be fixed.
ECMAScript Modules (ESM) support first appeared without a command-line flag in Node.js v14: https://nodejs.org/docs/latest-v14.x/api/esm.html
In Node,
import
does not work with.json
files (without another command-line flag), that's why in #1623 I replaced them and in #1625 implemented a workaround.To do after this is merged
esm
dependency frompackage.json
import/no-duplicates
ruleimport/order
ruleimport/newline-after-import
ruleimport/first
ruleimport/exports-last
ruleunicorn/import-style
configuration withno-restricted-imports
unicorn/prefer-node-protocol
rule once Supportnode:
protocol unjs/jiti#30 is fixed