Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixture 'cameo/zenit-w600' #579

Merged
merged 9 commits into from
Aug 10, 2018
Merged

Add fixture 'cameo/zenit-w600' #579

merged 9 commits into from
Aug 10, 2018

Conversation

FloEdelmann
Copy link
Member

  • Add fixture 'cameo/zenit-w600'
  • Update register.json

Fixture warnings / errors

  • cameo/zenit-w600
    • ❌ File does not match schema. [ { keyword: 'enum',
      dataPath: '.physical.DMXconnector',
      schemaPath: '#/properties/physical/properties/DMXconnector/enum',
      params:
      { allowedValues:
      [ '3-pin',
      '5-pin',
      '3-pin (swapped +/-)',
      '3-pin and 5-pin',
      '3-pin XLR IP65',
      '3.5mm stereo jack' ] },
      message: 'should be equal to one of the allowed values' } ]

Thank you @FloEdelmann!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels Aug 10, 2018
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-579 August 10, 2018 08:57 Inactive
@FloEdelmann
Copy link
Member Author

Broken links

(Output of test script tests/http-status.js.)

There were 0 internal and 2 external links failing.

@FloEdelmann
Copy link
Member Author

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ cameo / zenit-w600: d-light / attributes-correctness
  • ✔️ cameo/zenit-w600-2ch.xml
  • ✔️ cameo/zenit-w600-3ch.xml
  • ✔️ cameo/zenit-w600-4ch.xml
  • ✔️ cameo/zenit-w600-8ch1.xml
  • ✔️ cameo/zenit-w600-8ch2.xml
  • ✔️ cameo/zenit-w600-10ch.xml
  • ✔️ cameo/zenit-w600-15ch.xml
cameo / zenit-w600: millumin / json-schema-conformity
  • ❌ cameo/zenit-w600.json[ { "keyword": "enum", "dataPath": ".physical.DMXconnector", "schemaPath": "#/properties/physical/properties/DMXconnector/enum", "params": { "allowedValues": [ "3-pin", "5-pin", "3-pin (swapped +/-)", "3-pin and 5-pin", "3-pin XLR IP65", "3.5mm stereo jack" ] }, "message": "should be equal to one of the allowed values" } ]
cameo / zenit-w600: qlcplus_4.11.2 / xsd-schema-conformity
✔️ cameo / zenit-w600: qlcplus_4.12.0 / fixture-tool-validation
  • ✔️ cameo-Zenit-W600.qxf
cameo / zenit-w600: qlcplus_4.12.0 / xsd-schema-conformity

@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-579 August 10, 2018 09:17 Inactive
@FloEdelmann
Copy link
Member Author

Schema has changed

(Output of test script tests/github/schema-version-reminder.js.)

With every change on the schema, its version should be incremented and tagged. See the Fixture README for further information.

Copy link
Member Author

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fxedel fxedel merged commit bd4eb1c into master Aug 10, 2018
@fxedel fxedel deleted the branch2018-08-10T08-57-22 branch August 10, 2018 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants