Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbt: Add DREMIO to supported dbt profile types #2669

Closed
wants to merge 3 commits into from
Closed

dbt: Add DREMIO to supported dbt profile types #2669

wants to merge 3 commits into from

Conversation

surisimran
Copy link
Contributor

Problem

The dbt provider has a hardcoded set of supported dbt connection types. This adds dremio to the list.

Closes: #2668

Solution

Add static DREMIO to the Adapter(Enum)

Add an if clause for DREMIO to DbtArtifactProcessor.extract_namespace

  • Your change modifies the core OpenLineage model
  • Your change modifies one or more OpenLineage facets

One-line summary:

Add support for dbt-dremio, solving #2668

Checklist

  • You've signed-off your work
  • Your pull request title follows our guidelines
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • Your comment includes a one-liner for the changelog about the specific purpose of the change (if necessary)
  • You've versioned the core OpenLineage model or facets according to SchemaVer (if relevant)
  • You've added a header to source files (if relevant)

SPDX-License-Identifier: Apache-2.0
Copyright 2018-2023 contributors to the OpenLineage project

@boring-cyborg boring-cyborg bot added the area:integration/common openlineage-integration-common label May 6, 2024
Copy link

boring-cyborg bot commented May 6, 2024

Thanks for opening your first OpenLineage pull request! We appreciate your contribution. If you haven't already, please make sure you've reviewed our guide for new contributors (https://github.com/OpenLineage/OpenLineage/blob/main/CONTRIBUTING.md).

@surisimran surisimran closed this May 6, 2024
@surisimran
Copy link
Contributor Author

Will add sign-off and initiate it again

@surisimran surisimran deleted the add-dbt-dremio branch May 6, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:integration/common openlineage-integration-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[INTEGRATION] dbt-dremio
1 participant