-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Set aero default #666
Draft
xjjiang
wants to merge
57
commits into
OpenMDAO:main
Choose a base branch
from
xjjiang:set_aero_default_try_again
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+263
−381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aero.py and table_based.py
…sed/test/test_solved_aero_group.py will fail.
…craft.HorizontalTail.SWEEP = 0 in gaspaero.py and basic_calculations.py
…10.13, but keep Aircraft.HorizontalTail.SWEEP = 25.0
…COEFFICIENT_INCREMENT, Aircraft.Fuselage.FLAT_PLATE_AREA_INCREMENT, Aircraft.Design.DRAG_COEFFICIENT_INCREMENT, Aircraft.Fuselage.FLAT_PLATE_AREA_INCREMENT, Aircraft.Wing.MIN_PRESSURE_LOCATION to default in AeroGeom of gaspaero.py
…UBSONIC_DRAG_COEFF_FACTOR, Aircraft.Design.SUPERSONIC_DRAG_COEFF_FACTOR, Aircraft.Design.LIFT_DEPENDENT_DRAG_COEFF_FACTOR, Aircraft.Design.ZERO_LIFT_DRAG_COEFF_FACTOR to defaults in DragCoefClean of gaspaero.py
…aft.Wing.THICKNESS_TO_CHORD_ROOT, Aircraft.Wing.SPAN, Aircraft.Wing.SLAT_CHORD_RATIO to default in BasicFlapsCalculations of basic_calculations.py
…_DEFLECTION, Aircraft.Wing.ROOT_CHORD, Aircraft.Fuselage.LENGTH, Aircraft.Wing.LEADING_EDGE_SWEEP, Aircraft.Wing.SLAT_SPAN_RATIO to default in BasicFlapsCalculations of basic_calculations.py
…ENT_OPTIMUM, Aircraft.Wing.LOADING to defaults in Cl_max.py
…VISCOSITY, and Dynamic.Atmosphere.MACH using add_aviary_input and add_aviary_output.
…G_INCREMENT_OPTIMUM to defaults.
….Wing.SLAT_LIFT_INCREMENT_OPTIMUM Aircraft.Wing.FLAP_CHORD_RATIO to defaults.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A draft
Related Issues
Backwards incompatibilities
None
New Dependencies
None