Trajectory.phases subgroup is now available before setup. #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added finite burn orbit raise test with connected phases to test access to the phases subgroup before setup.
naylor-b
approved these changes
Jul 13, 2022
| @@ -17,7 +17,7 @@ | |||
| class TestExampleTwoBurnOrbitRaiseMPI(unittest.TestCase): | |||
There was a problem hiding this comment.
Should require petsc in addition to MPI here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In situations where the user might want to change attributes of the
Trajectory.phasesParallelGroup, such as setting solvers, this should be done before setup time.This was previously not possible because
phaseswasn't instantiated untilsetup.This pull request instantiates
phasesat Trajectory instantiation.Related Issues
Trajectory.phasesattribute available before setup. #776Backwards incompatibilities
None
New Dependencies
None