Timeseries Expressions #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is an expression
…its input variables
…es output is an expression. If it is, then the output name option is used instead of the name
…ensured no white spaces are left in variable names
…n the explicit shooting transcription
…apalli/dymos into timeseries_expr
…apalli/dymos into timeseries_expr
robfalck
requested changes
Oct 27, 2022
|
|
||
| class TimeseriesOutputGroup(om.Group): | ||
| def initialize(self): | ||
| self.options.declare('timeseries_output_comp', types=TimeseriesOutputCompBase, |
There was a problem hiding this comment.
adding option recordable=False will silence a lot of the warnings showing up on CI.
| @@ -276,9 +281,10 @@ def setup_timeseries_outputs(self, phase): | |||
| output_subset=options['subset'], | |||
| time_units=phase.time_options['units']) | |||
|
|
|||
| phase.add_subsystem(name, subsys=timeseries_comp) | |||
| timeseries_group = TimeseriesOutputGroup(has_expr=has_expr, timeseries_output_comp=timeseries_comp) | |||
| phase.add_subsystem(name, subsys=timeseries_group) | |||
There was a problem hiding this comment.
use argument promotes_inputs=['*'], promotes_outputs=['*'] here so that things can be addressed as timeseries.foo rather than timeseries.timeseries_comp.foo elsewhere in the code. That should make the contents of the timeseries group irrelevant to the user.
As long as you do this promotion for both the enclosed exec comp and the enclosed TimeseriesComp, connections will not have to change and any common inputs between the two components will be implicitly connected.
…pass keyword arguments to the enclosed ExecComp.
…ik_timeseries_expr
robfalck
approved these changes
Nov 2, 2022
More test and timeseries expression keyword arguments
… avoid mangling absolute shape and relative shape
|
I'm going to merge this in and deal with the latest jaxlib issue after. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added capability to add custom expressions as outputs to the timeseries.
Related Issues
Backwards incompatibilities
Minor changes to how timeseries outputs are called.
Where previously
p.model.phase0.timeseries.get_io_metadata(iotypes=('input', 'output'), get_remote=True)would return a dict keyed bystates:foo, nowp.model.phase0.timeseries.timeseries_comp.get_io_metadata(iotypes=('input', 'output'), get_remote=True)must be called.Similarly, when using
output_dict = dict(p.model.list_outputs()), the resulting dict is keyed bytraj.phases.phase0.timeseries.timeseries_comp.fooinstead oftraj.phases.phase0.timeseries.fooAn alternative is to call
get_promoted_vars(p.model, io_types='output'). This will yield a dict keyed bytraj.phase0.timeseries.fooNew Dependencies
None