Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test update_config.diff with more compatibility #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Test update_config.diff with more compatibility #25

wants to merge 2 commits into from

Conversation

velomatt
Copy link
Contributor

@velomatt velomatt commented Feb 9, 2023

This PR is mostly to test the resulting artifacts. If the change works and is performant, we may want to consider merging to main.

@velomatt velomatt requested a review from benixon February 9, 2023 21:29
@velomatt velomatt requested a review from a team as a code owner February 9, 2023 21:29
@velomatt velomatt linked an issue Feb 9, 2023 that may be closed by this pull request
Create compatible build artifact #24
Open
velomatt
velomatt commented Feb 9, 2023
View reviewed changes
Copy link
Contributor Author

@velomatt velomatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't work.

(base) [root@msl-dpe-perf36 bin]# LD_LIBRARY_PATH=/usr/dss/nkv-target/lib/ ./mkfs_blobfs2
Illegal instruction (core dumped)

@benixon benixon force-pushed the 24-create-compatible-build-artifact branch from 59cad95 to 757215e Compare February 15, 2023 19:46
@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benixon benixon Awaiting requested review from benixon

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create compatible build artifact
2 participants
@velomatt @benixon