Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating required args for nkv test cli #44

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Updating required args for nkv test cli #44

merged 1 commit into from
Jun 30, 2023

Conversation

nsarras
Copy link
Contributor

@nsarras nsarras commented Jun 27, 2023

No description provided.

@nsarras nsarras linked an issue Jun 27, 2023 that may be closed by this pull request
Patch nkv_test_cli gen2 regression #43
Closed
@nsarras nsarras marked this pull request as ready for review June 27, 2023 19:52
@nsarras nsarras requested a review from a team as a code owner June 27, 2023 19:52
@nsarras
Copy link
Contributor Author

nsarras commented Jun 27, 2023

successfully tested with nkv cli

@nsarras nsarras closed this Jun 27, 2023
@nsarras nsarras reopened this Jun 27, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

velomatt
velomatt approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@velomatt velomatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed resolves undefined var issue.

@velomatt velomatt merged commit 20df06d into master Jun 30, 2023
8 checks passed
@velomatt velomatt deleted the 43-patch-nkv_test_cli-gen2-regression branch June 30, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@velomatt velomatt velomatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Patch nkv_test_cli gen2 regression
2 participants
@nsarras @velomatt