-
Notifications
You must be signed in to change notification settings - Fork 55
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
0a3ad66
commit cae748a
Showing
3 changed files
with
0 additions
and
0 deletions.
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
cae748a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timosachsenberg
cae748a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add files and comments to the pr. Did you directly push this to master?
cae748a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have pushed the images to master, but for the documentation, I created a PR.
cae748a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For next time: a PR is the logical unit for the set of changes you want to introduce. It also contains new/renamed/moved files etc. If you separate e.g. doc and images then you end up with inconsistent/incomplete states of the repository. Failing ci etc. also if your PR would be closed without merge you would have unused files in the repo…
cae748a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timosachsenberg and for this can you guide me how to change the master branch to the same PR of documentation?
cae748a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s ok. Would just be extra work now. E.g. git reverting the commit on master and then reintroducing this commit in your pr with git cherry-pick…