Skip to content

Commit

Permalink
Add files via upload
Browse files Browse the repository at this point in the history
  • Loading branch information
Ayesha-Feroz authored Nov 22, 2023
1 parent 0a3ad66 commit cae748a
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 0 deletions.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

6 comments on commit cae748a

@Ayesha-Feroz
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timosachsenberg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add files and comments to the pr. Did you directly push this to master?

@Ayesha-Feroz
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have pushed the images to master, but for the documentation, I created a PR.

@timosachsenberg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For next time: a PR is the logical unit for the set of changes you want to introduce. It also contains new/renamed/moved files etc. If you separate e.g. doc and images then you end up with inconsistent/incomplete states of the repository. Failing ci etc. also if your PR would be closed without merge you would have unused files in the repo…

@Ayesha-Feroz
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timosachsenberg and for this can you guide me how to change the master branch to the same PR of documentation?

@timosachsenberg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s ok. Would just be extra work now. E.g. git reverting the commit on master and then reintroducing this commit in your pr with git cherry-pick…

Please sign in to comment.