Fix Varien_Io_File ignored errors with error control operator #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: lib/Varien
luigifab
commented
Oct 19, 2020
kkrieger85
added
the
hacktoberfest
- fclose supplied resource is not a valid stream resource - chdir No such file or directory (errno 2) - chmod no such file or directory
- imagedestroy supplied resource is not a valid Image resource - fclose supplied resource is not a valid stream resource
4 tasks
|
Can we get this merged pls? |
luigifab
commented
Jan 12, 2022
addison74
previously approved these changes
Jan 12, 2022
woutersamaey
previously approved these changes
Jan 12, 2022
|
I can't "Approve me". That's scandalous! |
kiatng
requested changes
Mar 23, 2022
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
fballiano
previously approved these changes
May 2, 2022
kiatng
previously approved these changes
May 3, 2022
luigifab
commented
May 6, 2022
lib/Varien/Io/File.php
Outdated
| if ($this->_streamLocked) { | ||
| $this->streamUnlock(); | ||
| } | ||
| @fclose($this->_streamHandler); | ||
| if (is_resource($this->_streamHandler)) { |
There was a problem hiding this comment.
From #2040, this is not good, there is a better way with $this->_IsValidSource().
luigifab
changed the title
addison74
approved these changes
Jul 4, 2022
|
Strange, it doesn't appear for me... Yes it is still present for permission denied. |
|
weird, you're not the only one who doesn't see those... |
fballiano
approved these changes
Jul 5, 2022
elidrissidev
pushed a commit
to elidrissidev/magento-lts
that referenced
this pull request
Jul 9, 2022
elidrissidev
pushed a commit
to elidrissidev/magento-lts
that referenced
this pull request
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix some (perhaps not all)
Varien_Io_Fileignored errors with error control operator.fclose supplied resource is not a valid stream resourcechdir: No such file or directory (errno 2)chmod: No such file or directoryI hope it's good.
OpenMage 20.0.10 - 20.0.13 / PHP 7.4.6 and 8.0.5 - 8.0.14
Manual testing scenarios
Contribution checklist