Create/Update .htaccess file in skin and media directories #2289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think (I guess @luigifab would too) that we shouldn't have all those empty lines :-D |
|
I agree in other files such as css, js, php, but here we need visibility. I kept the same format as in the .htaccess located in /root where I will propose a larger change these days. The new PR will be on the same format |
|
I see, although I still have a different opinion |
fballiano
approved these changes
Jul 8, 2022
elidrissidev
approved these changes
Jul 8, 2022
elidrissidev
pushed a commit
to elidrissidev/magento-lts
that referenced
this pull request
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the file format for /media/.htaccess.
I created .htaccess file in /skin directory. This change doesn't permit executing CGI scripts like in /media and /js (OM-20) directories.