Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[preview] get rid of "Adminhtml" #2533

Closed
wants to merge 5 commits into from
Closed

[preview] get rid of "Adminhtml" #2533

wants to merge 5 commits into from

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Sep 1, 2022

Description (*)

I'd like to get rid off Adminhtml. It is just a collection of classes that belong to a specific module.

My idea is to move all code to correct place and keep empty/deprecated adminhtml-classes for BC (like mysql4-classes).

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@sreichel sreichel marked this pull request as draft September 1, 2022 01:34
@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Api PageRelates to Mage_Api labels Sep 1, 2022
@justinbeaty
Copy link
Contributor

I would definitely support this, but question:

if we are changing the block class names, are we updating these in all the layout xml files and in any PHP where we createBlock manually? Or do we continue to call adminhtml/blockname ?

@sreichel
Copy link
Contributor Author

sreichel commented Sep 1, 2022

This is why it is on draft.

I dont want to change anything for layouts/xml ... so class names have to be resolved in another way.

Edit: 1st step would be to move code to correct place and deprecate classes. It had no impact to nothing. Drop that classes is something else ...

@kiatng
Copy link
Contributor

kiatng commented Sep 1, 2022

This PR will make it easier to uninstall non-required modules, ref PR #2455. With an uninstall script, the files in app/code/core/Mage/, app/design, app/etc/modules, and other folders, can be removed to achieve a clean uninstall.

On that perspective, we can keep the code for the required modules in Adminhtml.

@github-actions github-actions bot added the Component: Backup Relates to Mage_Backup label Sep 7, 2022
@sreichel sreichel closed this Sep 16, 2022
@addison74
Copy link
Contributor

Why did you close this draft? Any solid reason? I liked the idea.

@sreichel
Copy link
Contributor Author

I'll reopen later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Api PageRelates to Mage_Api Component: Backup Relates to Mage_Backup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants