Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Undefined variable $res in Mage_Core_Model_Cache #3255

Merged
merged 1 commit into from
May 15, 2023
Merged

Fixed Undefined variable $res in Mage_Core_Model_Cache #3255

merged 1 commit into from
May 15, 2023

Conversation

fballiano
Copy link
Contributor

After #3246 a new error is generated: #3246 (comment) and it's pretty clear (from the code) why.

to reproduce go to the backend, system -> cache and press "flush openmage cache"

@github-actions github-actions bot added the Component: Core Relates to Mage_Core label May 14, 2023
@sreichel sreichel mentioned this pull request May 14, 2023
4 tasks
@sreichel
Copy link
Contributor

sreichel commented May 14, 2023

to reproduce go to the backend, system -> cache and press "flush openmage cache"

Sorry for asking this ... how/why this was got approved? Did anyone tested it?

@addison74
Copy link
Contributor

As far as I can see, no one has approved this PR so far. I tried to reproduce the issue but I don't get any error, neither in the interface nor in the log files.

@sreichel
Copy link
Contributor

sreichel commented May 14, 2023

As far as I can see, no one has approved this PR so far.

Was related to #3246 (comment)

Copy link
Contributor

@kiatng kiatng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fballiano fballiano merged commit 00da425 into OpenMage:main May 15, 2023
@fballiano fballiano deleted the undefinedres branch May 15, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core Relates to Mage_Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants