Fixed passing null is deprecated for htmlspecialchars in Mage_Core_Helper_Abstract #3324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lool found the reason: some module |
kiatng
reviewed
Jun 19, 2023
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
|
I've commited @kiatng's version, I think it should be ok right? |
fballiano
approved these changes
Jun 22, 2023
addison74
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix
passing null to parameter 1 of type string is deprecatedforhtmlspecialcharswith PHP 8.1/8.2.Perhaps it's not the best way (I never had this warning when
$addSlashes=true).It seems that this appear on backend customer edit page.
See also this discussion comment.
Contribution checklist