Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated countries list #3436

Merged
merged 4 commits into from
Aug 14, 2023
Merged

Updated countries list #3436

merged 4 commits into from
Aug 14, 2023

Conversation

elidrissidev
Copy link
Member

@elidrissidev elidrissidev commented Aug 9, 2023 •
edited by addison74
Loading

Description (*)

I updated the countries list using the latest data from: https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2

Related

Manual testing scenarios (*)

  1. Apply the patch, clean the cache, and check that the data was updated.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Component: Directory Relates to Mage_Directory label Aug 9, 2023
@kiatng
Copy link
Contributor

kiatng commented Aug 10, 2023

How about Zend_Locale for country names?

@elidrissidev
Copy link
Member Author

How about Zend_Locale for country names?

I have no knowledge about that. Does it create an issue if they're not in Zend_Locale?

@elidrissidev
Copy link
Member Author

The new country names need to be added to zf1-future as well in order for them to be displayed properly. So this has to go back to draft until that's done.

@elidrissidev elidrissidev marked this pull request as draft August 11, 2023 08:51
@elidrissidev
Copy link
Member Author

elidrissidev commented Aug 11, 2023 •
edited
Loading

ouch there's soo many xml files to edit 😂 nvm they already exist in zf

@elidrissidev elidrissidev marked this pull request as ready for review August 11, 2023 09:09
fballiano
fballiano reviewed Aug 14, 2023
View reviewed changes
Copy link
Contributor

@fballiano fballiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

@fballiano fballiano changed the title Update countries list Updated countries list Aug 14, 2023
@fballiano fballiano merged commit 1668e3d into OpenMage:main Aug 14, 2023
15 checks passed
@elidrissidev elidrissidev deleted the chore/update-countries-list branch August 14, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flyingmana Flyingmana Flyingmana left review comments

@addison74 addison74 addison74 approved these changes

@empiricompany empiricompany empiricompany approved these changes

@mmenozzi mmenozzi mmenozzi approved these changes

@fballiano fballiano fballiano approved these changes

Assignees
No one assigned
Labels
Component: Directory Relates to Mage_Directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@elidrissidev @kiatng @Flyingmana @fballiano @mmenozzi @empiricompany @addison74