Fixed a Type Error when converting an Order with no Coupon to a Quote

[elidrissidev]

Description (*)

A small for a Type Error that occurs when converting an Order to a Quote, the coupon_code setter should accept null since the database field is nullable.

Related Pull Requests

• See Added getter/setter for getCouponCode() #2825

Fixed Issues (if relevant)

1. Fixes Uncaught TypeError: Mage_Sales_Model_Quote::setCouponCode() #3472

Manual testing scenarios (*)

$orderId = XXXXX;
$order = Mage::getModel('sales/order')->load($orderId);
$quote = Mage::getSingleton('sales/convert_order')->toQuote($order);

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[fballiano]

I would have removed the method, I don't see benefit in having it, but let's get this fixed however, which is far more important

[sreichel]

I would have removed the method, I don't see benefit in having it, but let's get this fixed however, which is far more important

Real methods are much more faster. (see #3245) From my POV - like in M2- every DB field should have its getter/setter methods. Already started it, but thats a lot of work. Type casting like (string) $xyz could or should be avoided. imho