Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate user supplied TARGET #1941

Merged
merged 3 commits into from
Dec 31, 2018
Merged

Validate user supplied TARGET #1941

merged 3 commits into from
Dec 31, 2018

Conversation

TiborGY
Copy link
Contributor

@TiborGY TiborGY commented Dec 29, 2018

This has a tiny side effect, the error gets triggered even during make clean, but otherwise it works as intended.

If the user supplies an incorrect TARGET in Makefile.rule, the build system should detect it and error out.
Fixes #1938
@TiborGY
Copy link
Contributor Author

TiborGY commented Dec 29, 2018

About the Travis failures:
-The ARM builds have timed out, no idea why, maybe the Travis servers are too busy
-There is one legitimate failure. I do not really understand how the Travis builds work, but the build parameters seem to be conflicting. First there is

export BTYPE="BINARY=64 NO_AFFINITY=1 USE_OPENMP=0 NO_LAPACK=0 TARGET=core2"

After that,

$ COMMON_FLAGS="DYNAMIC_ARCH=1 TARGET=NEHALEM NUM_THREADS=32"

Is this supposed to to be a CORE2 or a NEHALEM build? Also, why set DYNAMIC_ARCH=1, if you want a specific target?

@martin-frbg
Copy link
Collaborator

ARM tests are always timing out as the CI job runs on virtual hardware (qemu) - the idea is to use them for now to catch any glaring compile bugs, and set up automatic integration with a dedicated system later. (#1867).
The failing build is a good demonstration, setting TARGET in addition to DYNAMIC_ARCH can be useful when the build host is not autodetected, or to ensure that the common parts of the code (BLAS driver routines and the entire LAPACK) do not rely on "modern" cpu features present in the build system.

@martin-frbg martin-frbg reopened this Dec 29, 2018
@martin-frbg martin-frbg merged commit d11554c into OpenMathLib:develop Dec 31, 2018
@TiborGY TiborGY deleted the patch-3 branch January 19, 2019 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants