Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation and linking of the ctests on Windows/LLVM19 #4980

Closed
wants to merge 1 commit into from

Conversation

martin-frbg
Copy link
Collaborator

as implemented by h-vetinari in the LAPACK feedstock for conda-forge

@martin-frbg martin-frbg added this to the 0.3.29 milestone Nov 18, 2024
@isuruf
Copy link
Contributor

isuruf commented Nov 18, 2024

This is wrong behaviour for windows. We need to use __declspec(dllexport) and __declspec(dllimport) machinery.

@martin-frbg
Copy link
Collaborator Author

thanks - I had missed that there was a followup in https://github.com/conda-forge/lapack-feedstock/pull/76/files after h-vetinari pointed me to the original patch.
Guess these should ideally be upstreamed to Reference-LAPACK as well...

@isuruf
Copy link
Contributor

isuruf commented Nov 18, 2024

yes, I'll send a PR upstream

@martin-frbg
Copy link
Collaborator Author

On giving this a second look, the entire (original) patch should be relevant to the implementation of tests and xerbla in the Reference version of CBLAS only, so this PR is entirely spurious. (The OpenBLAS implementation uses neither the bytewise rewriting of Fortran character variables to C strings nor the deferred adjustment of error codes in the row major cases that the two global variables in the reference CBLAS are for)

@martin-frbg martin-frbg removed this from the 0.3.29 milestone Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants