illumos fixes #749
Merged
illumos fixes #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one was required too, but I don't know if it's going to break any other OSes so I didn't include it in this PR. https://github.com/lotheac/OpenBLAS/commit/66dcd655b665beebb1a7995a0c86cfd7af990dce |
the illumos linker can't understand the "-Y/lib"... form that f_check generates, and -Wl cannot pass options that include commas
|
I amended this with the f_check patch modification that you suggested in #700. It still builds fine, but I should note generally about this PR that while both Solaris and illumos identify as 'SunOS' in uname, there may be differences and I do not have a Solaris system to test these with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #700 and a few other issues with the build on illumos (OmniOS to be exact).