Bugfix/fix post install error #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roper app path Before, post_install command was running in the directory where syftbox app install is called
snwagh
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue in the
syftbox app install command related to the post-installation step. Previously, the post-install step executed commands based on the current working directory rather than the specific directory of the app being installed, as defined inconfig.json. This behavior caused inconsistencies when accessing app scripts and configurations. The PR modifies the implementation to ensure that the post-installation command now executes within the context of the app's installation path, guaranteeing that all app-specific scripts and configurations are correctly referenced and available during installation.Changes
Testing
You can test it by cloning this branch, installing the syftbox and running syftbox app install in a app repository that has a post_install pipeline defined. (eg:
IonesioJunior/ring)