Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cron to apps via config #142

Merged
merged 9 commits into from
Oct 16, 2024

Conversation

snwagh
Copy link
Contributor

@snwagh snwagh commented Oct 14, 2024

This adds the ability to run app by specifying schedules in the UNIX cron style (fun aside to create them).

Changes

  • This adds a new field schedule into the apps config.json file which is used by the client side to enforce running behaviour.
  • The default behaviour is set to * * * * * which is to run as soon as the app is called (which is done by the apps plugin every few seconds).

Testing

You can install this app using the command syftbox app install snwagh/syftbox-metadata and it should generate the /public/metadata/ folder with a metadata.json file in it with some basic content (with global view permissions but no write). This can be used by any search engine style thing running on syftbox.

Closes https://github.com/OpenMined/syft-internal-issues/issues/181

@snwagh snwagh requested a review from IonesioJunior October 14, 2024 23:39
syftbox/client/plugins/apps.py Outdated Show resolved Hide resolved
syftbox/client/plugins/apps.py Outdated Show resolved Hide resolved
@snwagh snwagh requested a review from abyesilyurt October 15, 2024 13:19
@IonesioJunior IonesioJunior self-requested a review October 16, 2024 19:23
Copy link
Member

@IonesioJunior IonesioJunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@IonesioJunior IonesioJunior merged commit 8ea787d into main Oct 16, 2024
7 checks passed
@IonesioJunior IonesioJunior deleted the snwagh/add-scheduler-to-apps-via-config branch October 16, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants