Ring Github Workflow #174
Closed
Ring Github Workflow #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Shubham Gupta <shubhamgupta3121@gmail.com>
experimenting with nohup to run uvicorn process Co-authored-by: Shubham Gupta <shubhamgupta3121@gmail.com>
Fixed environment error in app manager by passing only required parameters Co-authored-by: Shubham Gupta <shubhamgupta3121@gmail.com> Co-authored-by: Khoa Nguyen <khoaguin@users.noreply.github.com>
Co-authored-by: Shubham Gupta <shubhamgupta3121@gmail.com> Co-authored-by: Khoa Nguyen <khoaguin@users.noreply.github.com>
fix ring test expected values
Co-authored-by: Shubham Gupta <shubhamgupta3121@gmail.com> Co-authored-by: Khoa Nguyen <dkn.work@protonmail.com> Co-authored-by: Khoa Nguyen <khoaguin@users.noreply.github.com
Co-authored-by: Shubham Gupta <shubhamgupta3121@gmail.com> Co-authored-by: rasswanth-s <43314053+rasswanth-s@users.noreply.github.com>
Co-authored-by: Khoa Nguyen <khoaguin@users.noreply.github.com> Co-authored-by: Shubham Gupta <shubhamgupta3121@gmail.com>
Co-authored-by: Shubham Gupta <shubhamgupta3121@gmail.com> Co-authored-by: Khoa Nguyen <dkn.work@protonmail.com>
Co-authored-by: Shubham Gupta <shubhamgupta3121@gmail.com> Co-authored-by: Khoa Nguyen <dkn.work@protonmail.com>
yashgorana
reviewed
Oct 21, 2024
| DATA_DIR=./data | ||
|
|
||
| # remove the data directory | ||
| rm -rf $DATA_DIR |
There was a problem hiding this comment.
let's not do this - what's the use case? why do we need it?
| ) | ||
|
|
||
|
|
||
| #TODO: Solve name confusion in the server client before merge |
There was a problem hiding this comment.
what does this todo mean?
There was a problem hiding this comment.
shouldn't this live in the ring repo? we can test base functionality of ring over there?
and here we should just do an integration test if it is able to install and run the script.
add uv .python_version file to gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/OpenMined/syft-internal-issues/issues/174, https://github.com/OpenMined/syft-internal-issues/issues/133