Check python version compatibility in install script #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashgorana
requested changes
Oct 16, 2024
syftbox/server/templates/install.sh
Outdated
|
|
||
| # Check if Python version is greater than or equal to 3.10 | ||
| if [ "$major_version" -eq 3 ] && [ "$minor_version" -ge 10 ] || [ "$major_version" -gt 3 ]; then | ||
| echo "$python_command version is greater than or equal to 3.10" |
There was a problem hiding this comment.
please don't echo unnecessary stuff.
also no need to awk/cut... this can be truncated to. makes it more readable.
pyver_check=$(python_command -c "import sys; print(sys.version_info[:2] != (3, 10))")
if [ "$python_version_check" = "True" ]; then
err "Minimum python version is 3.10."
fi
There was a problem hiding this comment.
I think we should display the version of python the user is running if the minimum version doesn't match.
There was a problem hiding this comment.
would it matter? it's still unsupported
There was a problem hiding this comment.
err "Minimum python version is 3.10. Found $(python_command -V)"
- simplify version check command
yashgorana
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
Checklist