Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CD] Misc Changes #70

Merged
merged 5 commits into from
Oct 9, 2024
Merged

[CD] Misc Changes #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cb8127b
update readme with syftbox linking to pypi
rasswanth-s Oct 9, 2024
450f193
make git push to the checked-out branch
rasswanth-s Oct 9, 2024
444ddcf
add pre-release tests as pre-cursor to the release
rasswanth-s Oct 9, 2024
62b0186
update server instructions
rasswanth-s Oct 9, 2024
18b9970
typos
rasswanth-s Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion .github/workflows/cd-release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,15 @@ on:
description: "Perform a test bump version without pushing to pypi and repo"
type: boolean
default: false

skip_tests:
description: "If true, skip pre-release tests"
required: false
default: "false"
type: choice
options:
- "false"
- "true"

# Prevents concurrent runs of the same workflow
# while the previous run is still in progress
Expand All @@ -24,7 +33,13 @@ concurrency:
cancel-in-progress: false

jobs:
call-pr-tests:
if: ${{ inputs.skip_tests == 'false' }}
uses: ./.github/workflows/pr-tests.yaml


deploy-syftbox:
needs: [call-pr-tests]
runs-on: ubuntu-latest

steps:
Expand Down Expand Up @@ -70,4 +85,4 @@ jobs:
- name: Push changes to SyftBox repo
if: ${{ inputs.test_bump == false }}
run: |
git push origin main
git push origin
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will push the commit to the branch checked-out from , useful for testing the release pipeline from a PR before merging to main.

4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ curl -LsSf https://astral.sh/uv/install.sh | sh

uv venv .venv

## install the wheel
## Install Syftbox

uv pip install http://20.168.10.234:8080/wheel/syftbox-0.1.0-py3-none-any.whl --reinstall
uv pip install -U syftbox

## run the client

Expand Down
4 changes: 2 additions & 2 deletions syftbox/server/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,8 +179,8 @@ async def lifespan(app: FastAPI):
# create a virtualenv somewhere
uv venv .venv

# install the wheel
uv pip install http://20.168.10.234:8080/wheel/syftbox-0.1.0-py3-none-any.whl --reinstall
# Install SyftBox
uv pip install -U syftbox

# run the client
uv run syftbox client
Expand Down