Skip to content

Commit

Permalink
Remove hard coded min,max memory and allow users to pass JAVA_OPTS
Browse files Browse the repository at this point in the history
  • Loading branch information
mershad-manesh committed Mar 6, 2024
1 parent 4ed702e commit 2f2ca64
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 9 deletions.
2 changes: 1 addition & 1 deletion horizon/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.1.12
version: 1.1.13

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
2 changes: 1 addition & 1 deletion minion/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.1.12
version: 1.1.13

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
10 changes: 3 additions & 7 deletions minion/templates/minion-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,10 @@ spec:
value: /usr/lib/jvm/java-nocap
{{- end }}
{{- end }}
- name: JAVA_MAX_MEM
value: 2048M
- name: JAVA_MIN_MEM
value: 512M
{{- if .Values.truststore.content }}
- name: JAVA_OPTS
value: -Djavax.net.ssl.trustStore=/etc/java/jks/truststore.jks -Djavax.net.ssl.trustStorePassword={{ .Values.truststore.password }}
{{- end }}
value: |
{{ default "" .Values.minion.javaOpts }}
{{- if .Values.truststore.content }} -Djavax.net.ssl.trustStore=/etc/java/jks/truststore.jks -Djavax.net.ssl.trustStorePassword={{ .Values.truststore.password }} {{- end }}
- name: TZ
value: America/New_York
image: {{ $image }}
Expand Down
1 change: 1 addition & 0 deletions minion/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ minion:
requests:
cpu: '2'
memory: 4Gi
javaOpts: ''


core:
Expand Down

0 comments on commit 2f2ca64

Please sign in to comment.